Skip to content

gh-118911: Trailing whitespace in a block shouldn't prevent the user from terminating the code block#119355

Merged
ambv merged 8 commits intopython:mainfrom
aelsayed95:fix_issue_118911
May 22, 2024
Merged

gh-118911: Trailing whitespace in a block shouldn't prevent the user from terminating the code block#119355
ambv merged 8 commits intopython:mainfrom
aelsayed95:fix_issue_118911

Conversation

@aelsayed95
Copy link
Contributor

@aelsayed95 aelsayed95 commented May 21, 2024

Issue described in #118911

Fix includes:

  1. If the user hits enter twice, they are able to exit out of the block, even if there's trailing whitespace.
  2. Trim trailing whitespace in the HistoricalReader to match IPython's behavior

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-repl Related to the interactive shell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants